Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hjelpeknapp tekst, feil font #2002

Closed
DanRJ opened this issue Apr 5, 2024 · 4 comments
Closed

Hjelpeknapp tekst, feil font #2002

DanRJ opened this issue Apr 5, 2024 · 4 comments
Assignees
Labels
area/designsystem good-first-issue Issues that are easy to fix for new team members or external contributors kind/bug Something isn't working

Comments

@DanRJ
Copy link
Contributor

DanRJ commented Apr 5, 2024

Description of the bug

Hjelpeknapp tekst har font family Times New Roman selv om det står Inter i htmlen, jeg funderer på om Inter aldri blir lastet inn.
image

Steps To Reproduce

Åpne en hjelpeknapp og se på teksten, evt se bildet ovenfor

Additional Information

No response

@olemartinorg
Copy link
Contributor

Reprodusert lokalt, jeg får samme problem. Det ser ut til at designsystemet tvinger inter-fonten her, men i apps har vi ikke gått over til den fonten (enda). Dumt om font blir overstyrt fra designsystemet sin side.

Det kan også nevnes at denne feilen bør brukes som en anledning til å instruere Cypress til å klikke åpen en hjelpetekst i minst ett av skjermbildene som tas med Percy, slik at vi hadde fått et varsel om slike feil som dette (bør nok kombineres med et klikk på en lang/flerlinje-hjelpetekst, slik at vi får med hvordan det ser ut i samme slengen.

@RonnyB71 RonnyB71 added the good-first-issue Issues that are easy to fix for new team members or external contributors label Apr 10, 2024
@Magnusrm
Copy link
Contributor

Will get fixed by: #2009

@Magnusrm Magnusrm self-assigned this Apr 10, 2024
@Magnusrm Magnusrm moved this to 👷 In Progress in Team Apps Apr 10, 2024
@olemartinorg
Copy link
Contributor

Great! Does that mean that the issue I created in the design system (Altinn/altinn-design-system#339) is no longer an issue there, then? Or are we overriding the font in app-frontend?

Remember the previous point about creating Percy tests for this as well. 🙏

@rvessb rvessb removed this from Issues SSB Apr 10, 2024
@Magnusrm
Copy link
Contributor

It seems it is no longer an issue 😊 Tested with the same app-frontend app version. And the new DS version fixes it.
I'll remember to add a percy test! 👍

@Magnusrm Magnusrm moved this from 👷 In Progress to 🔎 Review in Team Apps Apr 17, 2024
@Magnusrm Magnusrm moved this from 🔎 Review to 🧪 Test in Team Apps Apr 17, 2024
@HanneLauritsen1967 HanneLauritsen1967 moved this from 🧪 Test to ✅ Done in Team Apps Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/designsystem good-first-issue Issues that are easy to fix for new team members or external contributors kind/bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants