Panel with groupReference seems broken

[olemartinorg]

In #976, I refactored the way a Panel with a reference to another repeating group has its data model bindings resolved. I also removed some broken tests, and fixed some issues in the frontend-test app that made this functionality severely broken there as well.

It's now pretty clear how this functionality was supposed to work, but it's also very apparent that it doesn't work (and #976 did not change this, it also didn't work before that). In our group.ts cypress tests, we have a test-case for the Panel with group functionality, but as our test-app has been crashing when selecting an existing row in that functionality since it was introduced, I suspect the tiny test is not actually testing all the expected functionality.

So, this issue includes tasks to:

• Figure out if the "save" button in this Panel makes sense. We don't have active "save" buttons anywhere else, and everything you type/fill in to components are saved on-the-fly.
• Fix the functionality so that it works. Also look at related issues to see if any of these are easy to fix:
  • Large icons in Panel with groupReference #974
  • Repeating groups: Panel i repeterende gruppe lukker seg ved bruke av mapping på dropdown i samme gruppe #639
  • Repeating groups: Panel i repeterende gruppe, ved validate row og bruk av panel så valideres raden i gruppen som Panel refererer til. #634
  • Repeating groups: Panel i repeterende grupper støtter ikke avbryt #601
• Improve the cypress test in group.ts to include:
  • Adding a reference to an existing row (not just adding a new one)
  • Make absolutely sure the test is not filling out the row in the first group (the test seems to pass, but manually filling this out force-closes the panel as soon as the first field is saved)
  • Add a test-case for what happens when deleting the referenced row in the source repeating group
• Recreate unit-tests or cypress-tests that were deleted/broken:
  • Verify the expected functionality for a group with panel and groupReference, but without any child components of its own (does it inherit the components from the referenced group? check the documentation and how the functionality was expected to work)
  • Verify that you can pass a custom icon via component properties to the panel
• Remove the TODO in PanelGroupContainer.tsx once it is solved

[olemartinorg]

This functionality is no longer present in v4, so the brokenness has been successfully fixed by removal. 🥳