Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo audit flags smallvec, recommends update to >=6.3 #95

Closed
jackcmay opened this issue Sep 21, 2018 · 6 comments
Closed

Cargo audit flags smallvec, recommends update to >=6.3 #95

jackcmay opened this issue Sep 21, 2018 · 6 comments

Comments

@jackcmay
Copy link

error: Vulnerable crates found!

ID: RUSTSEC-2018-0003
Crate: smallvec
Version: 0.2.1
Date: 2018-07-19
URL: servo/rust-smallvec#96
Title: Possible double free during unwinding in SmallVec::insert_many
Solution: upgrade to: >= 0.6.3 OR ^0.3.4 OR ^0.4.5 OR ^0.5.1

smallvec = "0.6"

@Amanieu
Copy link
Owner

Amanieu commented Sep 21, 2018

Well technically just specifying the version as "0.6" should be enough for Cargo to pick up the latest version, which includes the fix.

@jackcmay
Copy link
Author

Hmm, wonder why cargo audit is flagging it then :-(

@CryZe
Copy link
Contributor

CryZe commented Sep 22, 2018

I guess it does it because 0.6 can technically resolve to 0.6.1 or so, which is vulnerable. That's a bit overly pedantic though maybe.

@jackcmay
Copy link
Author

Agreed, are you opposed to changing it to 0.6.3?

@Amanieu
Copy link
Owner

Amanieu commented Sep 24, 2018

I will accept a PR for it if anyone wants to write one.

@jackcmay
Copy link
Author

Thanks for the attention, looks like Cargo audit is not flagging this instance and is instead flagging another project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants