From 712988504314b3878904687ded2e509a26609579 Mon Sep 17 00:00:00 2001
From: Alex Tkachev <alex.leksat@gmail.com>
Date: Tue, 1 Jun 2021 11:39:35 +0300
Subject: [PATCH] fix: suppress missing arguments error in other way

Apparently, Gatsby waits for the callback call if createPages has the callback in its definition. Before this commit the build was stuck at "createPages" step.
---
 apps/silverback-gatsby/gatsby-node.ts              | 14 +++++++-------
 .../gatsby-node-helpers/create-pages/articles.ts   |  7 +++----
 .../create-pages/gutenberg-pages.ts                |  7 +++----
 3 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/apps/silverback-gatsby/gatsby-node.ts b/apps/silverback-gatsby/gatsby-node.ts
index bf077e15b2..cd524b50ed 100644
--- a/apps/silverback-gatsby/gatsby-node.ts
+++ b/apps/silverback-gatsby/gatsby-node.ts
@@ -3,11 +3,11 @@ import { GatsbyNode } from 'gatsby';
 import { createArticlePages } from './src/gatsby-node-helpers/create-pages/articles';
 import { createGutenbergPages } from './src/gatsby-node-helpers/create-pages/gutenberg-pages';
 
-export const createPages: GatsbyNode['createPages'] = async (
-  args,
-  options,
-  callback,
-) => {
-  await createArticlePages(args, options, callback);
-  await createGutenbergPages(args, options, callback);
+export type CreatePagesArgs = Parameters<
+  Required<GatsbyNode>['createPages']
+>[0];
+
+export const createPages: GatsbyNode['createPages'] = async (args) => {
+  await createArticlePages(args);
+  await createGutenbergPages(args);
 };
diff --git a/apps/silverback-gatsby/src/gatsby-node-helpers/create-pages/articles.ts b/apps/silverback-gatsby/src/gatsby-node-helpers/create-pages/articles.ts
index 13b24bed64..c80946cbe1 100644
--- a/apps/silverback-gatsby/src/gatsby-node-helpers/create-pages/articles.ts
+++ b/apps/silverback-gatsby/src/gatsby-node-helpers/create-pages/articles.ts
@@ -1,12 +1,11 @@
-import { GatsbyNode } from 'gatsby';
-
+import { CreatePagesArgs } from '../../../gatsby-node';
 import { languages } from '../../constants/languages';
 import { ArticleContext } from '../../types/page-context';
 
-export const createArticlePages: Required<GatsbyNode>['createPages'] = async ({
+export const createArticlePages = async ({
   graphql,
   actions,
-}) => {
+}: CreatePagesArgs): Promise<void> => {
   // Create article pages. Notice that we fetch from Gatsby GraphQL, not from
   // Drupal.
   const { data, errors } = await graphql<AllArticlesQuery>(`
diff --git a/apps/silverback-gatsby/src/gatsby-node-helpers/create-pages/gutenberg-pages.ts b/apps/silverback-gatsby/src/gatsby-node-helpers/create-pages/gutenberg-pages.ts
index 6ba4216d88..9edaab1d59 100644
--- a/apps/silverback-gatsby/src/gatsby-node-helpers/create-pages/gutenberg-pages.ts
+++ b/apps/silverback-gatsby/src/gatsby-node-helpers/create-pages/gutenberg-pages.ts
@@ -1,12 +1,11 @@
-import { GatsbyNode } from 'gatsby';
-
+import { CreatePagesArgs } from '../../../gatsby-node';
 import { languages } from '../../constants/languages';
 import { GutenbergPageContext } from '../../types/page-context';
 
-export const createGutenbergPages: Required<GatsbyNode>['createPages'] = async ({
+export const createGutenbergPages = async ({
   graphql,
   actions,
-}) => {
+}: CreatePagesArgs): Promise<void> => {
   const { data, errors } = await graphql<AllGutenbergPagesQuery>(`
     query AllGutenbergPages {
       allDrupalGutenbergPageTranslations {