Clamp Billboards and Labels to terrain #2653

bagnell · 2015-04-21T20:26:40Z

NOTE: This is into the globe-depth branch because the globe depth texture is required.

Opening for early review. Still needs to be done:

Performance improvements
Doc
Tests

…errain WIP.

…moving a billboard.

…rphing.

…billboard and compare against an offset position in eye coordinates.

…iven time slice.

…d with an undefined position.

…ad of generating a random number.

…bel.

…sitions from not rendered to rendered. Update time slices.

mramato · 2015-04-21T21:37:16Z

I know we talked about this a little offline, but I propose we replace clampToGround with a heightReference property and new enum, HeightReference. The three initial choices would be NONE (i.e. just use the ECF position) CLAMP_TO_GROUND and RELATIVE_TO_GROUND (where the height of the position is added to the terrain height). This would also allow for easily adding new height references in the future (such as RELATIVE_TO_SEA_FLOOR or RELATIVE_TO_MSL). All of these are needed to support KML (and Google gx extensions).

Will Models be handled in similar fashion?

pjcozzi · 2015-04-21T22:59:18Z

I propose we replace clampToGround with a heightReference

OK with me.

Will Models be handled in similar fashion?

Yes.

pjcozzi · 2015-04-21T23:03:53Z

Source/Scene/Billboard.js

+                Cartesian3.clone(Cartesian3.UNIT_X, scratchRay.direction);
+            }
+
+            var position = object._newTile.data.pick(scratchRay, mode, projection, false, scratchPosition);


I imagine this is already part of the performance plans, but we must be able to optimize the general-purpose ray intersection given we have the specific case of a ray normal to the ellipsoid surface. I'm talking about the actual number crunching...this is in addition to the spatial data structure / adjacency info / temporal coherence / etc.

pjcozzi · 2015-04-21T23:05:21Z

Add an item to the terrain Sandcastle example
Update CHANGES.md

pjcozzi · 2015-04-21T23:08:17Z

Source/Shaders/BillboardCollectionVS.glsl

+#ifdef TEST_GLOBE_DEPTH
+    vec4 offsetPosition = positionEC + vec4(0.0, 0.0, -positionEC.z * 0.05, 0.0);
+    vec4 wc = computePositionWindowCoordinates(offsetPosition, vec2(0.0, 0.0), scale, direction, origin, vec2(0.0), pixelOffset, alignedAxis, rotation);
+    float d = texture2D(czm_globeDepthTexture, wc.xy / czm_viewport.zw).r;


What if number of vertex shader texture units is zero or depth textures are not supported? We don't need to throw an exception, but there should be a trivial way for the user to see if clamp-to-ground is supported and perhaps we should warn in the console if they ask if it and the system doesn't support it.

OK, thanks for reminding me. I wasn't sure whether to throw or not. I also need to check if we can create a fbo with a floating-point color attachment. I've had issues before where floating-point textures were supported but the fbos were incomplete.

pjcozzi · 2015-04-21T23:46:54Z

That's all for this round.

…e when we walk the tree. Add an event to the quadtree that fires when a tile is queued for rendering.

… none, clamp to ground or relative to ground. Clean up modifications to quadtree when destroying a billboard or label.

pjcozzi · 2015-05-04T21:23:41Z

I don't know if this is related to this issue (or Mac or Chrome vs. FF), but do you get horizontal black lines above and below labels?

pjcozzi · 2015-05-04T21:26:31Z

I also get billboards that are partly behind terrain:

Then zoom in and it is OK:

pjcozzi · 2015-05-04T21:27:49Z

Here's the WebGL Report if it is useful:

pjcozzi · 2015-05-04T21:35:01Z

I don't know if this is related to this issue (or Mac or Chrome vs. FF), but do you get horizontal black lines above and below labels?

Perhaps Chrome only. FF is OK.

bagnell · 2015-05-04T21:35:50Z

do you get billboards that disappear (and stay hidden until you move more) when zooming in

I've seen that for top-down views where a billboard or label is in a valley, but not for a horizon view like you posted. I'll try to reproduce it.

bagnell · 2015-05-04T21:36:40Z

do you get horizontal black lines above and below labels?

I haven't seen that. Perhaps Mac Chrome only?

bagnell · 2015-05-04T21:38:51Z

I also get billboards that are partly behind terrain

I've seen that at frustum boundaries. Is that the case for you?

pjcozzi · 2015-05-04T21:39:18Z

I also get billboards that are partly behind terrain:

Then zoom in and it is OK:

I'm pretty sure this is a multi-frustum issue (use Cesium Inspector to confirm). If the fix is non-trivial, I am OK with writing an issue for it and merging anyway.

pjcozzi · 2015-05-04T21:39:44Z

I also get billboards that are partly behind terrain
I've seen that at frustum boundaries. Is that the case for you?

Yes.

pjcozzi · 2015-05-04T21:43:53Z

do you get horizontal black lines above and below labels?
I haven't seen that. Perhaps Mac Chrome only?

Appears to be Mac and Chrome only. No concern.

pjcozzi · 2015-05-04T21:50:52Z

I submitted a few ideas to #2685. Update it as you see fit. The terrain heights are fast enough to merge this, but we should optimize them when we get some time.

pjcozzi · 2015-05-04T22:35:47Z

@bagnell did you check the bounding sphere?

bagnell · 2015-05-05T20:45:35Z

did you check the bounding sphere?

Yes. There were no code changes needed.

bagnell · 2015-05-05T20:48:28Z

@pjcozzi This is ready for another look.

I'm looking at the frustum issue. It's really noticeable if you switch to labels.

pjcozzi · 2015-05-05T22:57:50Z

I'm still getting issues. Here we are looking east:

Zoom in a bit and billboards disappear in the top left (north east corner):

Also, this can be too aggressive with the offset for the case where the billboard is on the face of Seneca Rocks and the viewer is on the other side and zooming out.

If we have to err one way or the other, I would rather be too aggressive about making labels visible, but I also think a smarter offset could get us a 90% win.

bagnell · 2015-05-05T23:41:12Z

You'll have to show me that tomorrow. I can't tell what is going on from the screen shot.

I've tried a bunch of different views and have been able to rationalize that its correct. I have seen billboards disappear as you zoom in because they are behind the terrain. As the billboards remain a constant size, parts pop out from behind the terrain. But, instead of only seeing that part, we determine that the whole thing should be visible so it pops into view.

pjcozzi · 2015-05-06T15:21:50Z

do you get horizontal black lines above and below labels?

I haven't seen that. Perhaps Mac Chrome only?

Appears to be Mac and Chrome only. No concern.

Fixed in the latest Chrome.

…adtree primitive update height callbacks.

bagnell · 2015-05-07T02:27:24Z

Add an item to the terrain Sandcastle example

Do we want to keep the development example I added? Should I still add an example to the terrain Sandcastle example or wait for entity support?

bagnell · 2015-05-07T02:27:39Z

@pjcozzi This is ready.

pjcozzi · 2015-05-07T16:25:55Z

Do we want to keep the development example I added?

I think so.

Should I still add an example to the terrain Sandcastle example or wait for entity support?

Wait.

pjcozzi · 2015-05-07T16:42:15Z

This is OK to go into the globe-depth branch, but given the flicker due to the false positives, I would not merge into master until we figure out #2691.

…o-ground Clamp Billboards and Labels to terrain

bagnell added 15 commits April 16, 2015 15:22

Clamp billboards to ground WIP.

19f3ff9

Hook up callbacks when loading tiles in the quadtree. Billboards on t…

45265e3

…errain WIP.

Update quadtree callbacks when billboards are added or removed.

db403b6

Move clamp control from billboard collection to billboard.

b7137f5

Track clamped position differently from user provided position.

ac3aee2

Improve performance by not updating entire quadtree when adding or re…

5298834

…moving a billboard.

Fix clamping to billboards to ground in 2D, Columbus view and when mo…

6abe6ed

…rphing.

Only use one vertex texture fetch for the depth at the center of the …

83f5dc3

…billboard and compare against an offset position in eye coordinates.

Merge branch 'globe-depth' into billboard-clamp-to-ground

cc013c4

Throttle billboards clamped to terrain to only pick the mesh in the g…

9a76c64

…iven time slice.

Add clamp to ground option to labels.

4583516

Clean up picking a terrain tile's mesh and fix billboards when create…

8840623

…d with an undefined position.

Use the frame number when updating callbacks for rendered tiles inste…

f115094

…ad of generating a random number.

Clamp the entire label instead of the individual billboards of the la…

27df468

…bel.

Check the last frame rendered and only use callbacks when a tile tran…

8ce9101

…sitions from not rendered to rendered. Update time slices.

pjcozzi reviewed Apr 21, 2015
View reviewed changes

bagnell added 2 commits April 22, 2015 14:42

Improve performance. Associate data with the quadtree that will updat…

0acc702

…e when we walk the tree. Add an event to the quadtree that fires when a tile is queued for rendering.

Change clampToGround boolean to heightReference with enum that can be…

fefe944

… none, clamp to ground or relative to ground. Clean up modifications to quadtree when destroying a billboard or label.

bagnell added 2 commits May 5, 2015 15:23

Fix ciolumbus view. Clean up requires.

9f7f1ab

Re-add eye z offset.

58980dc

bagnell added 3 commits May 6, 2015 21:34

Add tests for billboards/labels with height references and for the qu…

3b7c13b

…adtree primitive update height callbacks.

Merge branch 'globe-depth' into billboard-clamp-to-ground

83fd26d

Update CHANGES.md

9fff44c

pjcozzi mentioned this pull request May 7, 2015

Billboard/label on terrain flickering #2691

Closed

pjcozzi added a commit that referenced this pull request May 7, 2015

Merge pull request #2653 from AnalyticalGraphicsInc/billboard-clamp-t…

94dc317

…o-ground Clamp Billboards and Labels to terrain

pjcozzi merged commit 94dc317 into globe-depth May 7, 2015

pjcozzi deleted the billboard-clamp-to-ground branch May 7, 2015 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clamp Billboards and Labels to terrain #2653

Clamp Billboards and Labels to terrain #2653

bagnell commented Apr 21, 2015

mramato commented Apr 21, 2015

pjcozzi commented Apr 21, 2015

pjcozzi Apr 21, 2015

pjcozzi commented Apr 21, 2015

pjcozzi Apr 21, 2015

bagnell Apr 21, 2015

pjcozzi commented Apr 21, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

bagnell commented May 4, 2015

bagnell commented May 4, 2015

bagnell commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

bagnell commented May 5, 2015

bagnell commented May 5, 2015

pjcozzi commented May 5, 2015

bagnell commented May 5, 2015

pjcozzi commented May 6, 2015

bagnell commented May 7, 2015

bagnell commented May 7, 2015

pjcozzi commented May 7, 2015

pjcozzi commented May 7, 2015

Clamp Billboards and Labels to terrain #2653

Clamp Billboards and Labels to terrain #2653

Conversation

bagnell commented Apr 21, 2015

mramato commented Apr 21, 2015

pjcozzi commented Apr 21, 2015

pjcozzi Apr 21, 2015

Choose a reason for hiding this comment

pjcozzi commented Apr 21, 2015

pjcozzi Apr 21, 2015

Choose a reason for hiding this comment

bagnell Apr 21, 2015

Choose a reason for hiding this comment

pjcozzi commented Apr 21, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

bagnell commented May 4, 2015

bagnell commented May 4, 2015

bagnell commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

pjcozzi commented May 4, 2015

bagnell commented May 5, 2015

bagnell commented May 5, 2015

pjcozzi commented May 5, 2015

bagnell commented May 5, 2015

pjcozzi commented May 6, 2015

bagnell commented May 7, 2015

bagnell commented May 7, 2015

pjcozzi commented May 7, 2015

pjcozzi commented May 7, 2015