-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Draco support to point clouds #6559
Merged
Merged
Changes from 2 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
9cfba49
Added Draco loading to pnts
lilleyse c5870f8
Updated CHANGES.md
lilleyse ccc04ee
Merge branch 'master' into point-clouds-draco
lilleyse 706a918
Combine point cloud and model into the same draco loader
lilleyse f618fb0
Formatting updates
lilleyse 4ef9401
Tweaked CHANGES.md
lilleyse 929ce88
Change names of test data, update link in Sandcastle demo
lilleyse b153553
Merge branch 'master' into point-clouds-draco
lilleyse 845846c
Removed isPointCloud parameter
lilleyse a79b93f
Revert changes in #6558
lilleyse 054fc5b
Remove decodeDracoPointCloud
lilleyse 4156778
Merge branch 'master' into point-clouds-draco
lilleyse ebd98ca
Revert a79b93f
lilleyse 8e551be
Update Draco format
lilleyse 2f940d7
Support 8-bit Draco quantized points
lilleyse a552a9f
Fix when batch table doesn't exist
lilleyse 99040bc
Fix for batched points
lilleyse 4951e17
Adjustments to support a mix of draco and non-draco properties
lilleyse c54add9
Update tilesets and specs
lilleyse 258ebf8
Remove IE checks
lilleyse 0376b5d
Changed .include to .indexOf in some tests
lilleyse bea4f5b
Fix bad CHANGES.md merge
lilleyse 0c303b9
Updates
lilleyse d264443
Merge branch 'master' into point-clouds-draco
lilleyse 4dd4334
Merge branch 'master' into point-clouds-draco
lilleyse 52eac03
Merge branch 'master' into point-clouds-draco
lilleyse dc74460
Fix bad merge
lilleyse 41962c3
Merge branch 'master' into point-clouds-draco
lilleyse a67704e
Fix CHANGES.md bad merge again
lilleyse d9c3dee
Set isQuantized and isOctEncoded after Draco decode
lilleyse 3e96229
Fix tilesets
lilleyse 8efda1b
Destroy decoder
lilleyse c7948c4
Merge branch 'master' into point-clouds-draco
lilleyse 9e502b7
Update draco files
lilleyse 620d975
Move draco object creation
lilleyse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a tad more detail, e.g., "compressed", not "encoded", and something like "up to 10x" or whatever compression.