Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve underground rendering #8572

Merged
merged 16 commits into from
Mar 5, 2020
Merged

Improve underground rendering #8572

merged 16 commits into from
Mar 5, 2020

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jan 28, 2020

Detects if the camera is underground, and if it is:

  • Disable skirts
  • Disable back-face culling
  • Disable fog
  • Disable ellipsoid occlusion culling for both terrain tiles and primitives. Primitives inside the globe will not be culled.

artifacts

Known issues that don't need to hold up this PR:

  • Because skirts are disabled it's easy to see through terrain seams. Instead it would better to invert the skirts.
  • The depth plane is non-existent when you're underground so stuff above the surface on the opposite side of the globe will be visible. Like in this sandcastle (click "Add points")

Don't merge until after the February release, this needs more time to sit in master. Camera navigation PR to follow this one.

@fredj @gberaudo

@lilleyse lilleyse requested a review from IanLilleyT January 28, 2020 22:48
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Feb 26, 2020

@IanLilleyT @lilleyse is this still waiting for a review?

@lilleyse
Copy link
Contributor Author

@IanLilleyT's going to review after Friday, it's ok if this doesn't make the March release.

@IanLilleyT
Copy link
Contributor

Looks good to me, thanks @lilleyse !

@IanLilleyT IanLilleyT merged commit c4306da into master Mar 5, 2020
@lilleyse lilleyse deleted the camera-underground branch March 5, 2020 02:35
gberaudo pushed a commit to swisstopo/swissgeol-viewer-app that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants