Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevation and elevation shadow color #48

Closed
anisalibegic opened this issue May 4, 2019 · 5 comments
Closed

Elevation and elevation shadow color #48

anisalibegic opened this issue May 4, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@anisalibegic
Copy link

Hey, thanks for the plugin! Can you add elevation and elevation shadow color properties along with boxShadow?

@anisalibegic anisalibegic changed the title Elevation Elevation and elevation shadow color May 4, 2019
@AndreHaueisen
Copy link
Owner

Hi @grandpa-guru
That is already built in BoxShadow's properties.

@anisalibegic
Copy link
Author

anisalibegic commented May 4, 2019

Hi @grandpa-guru
That is already built in BoxShadow's properties.

If you check the material source code you will find out that elevation maps to the list of BoxShadow instancies but this plugin accepts only one BoxShadow instance. Two ways of solving:

  1. Allow passing the list of BoxShadow instances
  2. Add elevation and elevation shadow color to the already existing Material widget int the build method on the line 298

Can you please show an example with the elevation 8 and elevation shadow color Colors.black54?

@AndreHaueisen AndreHaueisen added the enhancement New feature or request label May 4, 2019
@AndreHaueisen
Copy link
Owner

Ok. That makes sense. Since it is a simple change, I will push a new version supporting a list of BoxShadows latter today. I won't map it to specific elevations though.

@AndreHaueisen AndreHaueisen reopened this May 4, 2019
@anisalibegic
Copy link
Author

Ok. That makes sense. Since it is a simple change, I will push a new version supporting a list of BoxShadows latter today. I won't map it to specific elevations though.

Thank you! Maybe you could add the material source code to the property documentation in your code.

@AndreHaueisen
Copy link
Owner

Thanks for the feedback. Change live on version 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants