Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnTap issue #72

Closed
Paul-Todd opened this issue Jul 29, 2019 · 2 comments
Closed

OnTap issue #72

Paul-Todd opened this issue Jul 29, 2019 · 2 comments

Comments

@Paul-Todd
Copy link

Is the implementation of the onTap function correct?

It works if I do this:

(Flushbar fb) {
                      fb.dismiss(true);
                      return () {};
                    },

I don't know why I need to return an empty function as this seems to be overkill and it is never used in the code.

Maybe the intention was to return a Future which could then be chained and tell the caller once the dismiss is complete?

@AndreHaueisen
Copy link
Owner

Hi @Paul-Todd
Uu my bad there. Will push a fix for that today.
Thanks for reporting.

@AndreHaueisen
Copy link
Owner

Live at 1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants