Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charity Registration: Create Steps Dashboard according to new design #735

Merged
merged 28 commits into from
Feb 24, 2022
Merged

Charity Registration: Create Steps Dashboard according to new design #735

merged 28 commits into from
Feb 24, 2022

Conversation

0xNeshi
Copy link
Contributor

@0xNeshi 0xNeshi commented Feb 22, 2022 •
edited
Loading

Closes #638

Description of the Problem / Feature

This component first needs refactoring, to simplify adding new components and flow logic. Then add step #4 "Additional information" according to new flow in Charity_Registration_flow_v0.7.2.pdf (page 7).

Conditions of Satisfaction

What does it mean to be done with this issue

  • RegistrationStatus is refactored (redundant html removed, added hooks to improve performance/remove bugs)
  • added step 4
  • add button "Submit for review" that appears while data is being filled
  • add new component for "Status of your endowment" that appears after submission (.pdf -> pages 11, 12, 13)

Explanation of the solution

  • Added/renamed necessary components for the Steps Dashboard
  • Created a scaffold for the step # 3 and step # 4 logic (which is to be implemented next)

Instructions on making this work

  • run the app
  • start registration process at /app/register
  • update parts of code to make certain dashboard components (dis)appear

UI changes for review

image

image

image

image

image

@0xNeshi 0xNeshi self-assigned this Feb 22, 2022
@0xNeshi 0xNeshi changed the title Update reg status Charity Registration: Create Steps Dashboard according to new design Feb 22, 2022
@0xNeshi 0xNeshi changed the base branch from RC-charity-registration to staging February 23, 2022 10:29
@0xNeshi 0xNeshi changed the base branch from staging to RC-charity-registration February 23, 2022 10:29
@0xNeshi 0xNeshi marked this pull request as ready for review February 23, 2022 12:15
@0xNeshi 0xNeshi linked an issue Feb 23, 2022 that may be closed by this pull request
Charity Registration: Refactor RegistrationStatus according to new design #638
Closed
4 tasks
SovereignAndrey
SovereignAndrey approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@SovereignAndrey SovereignAndrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise it looks good. 💯 One small niggle on a sentence wording for now (plz see my comment).

@0xNeshi 0xNeshi merged commit 1db0fd3 into RC-charity-registration Feb 24, 2022
@0xNeshi 0xNeshi deleted the update-reg-status branch February 24, 2022 06:46
@0xNeshi 0xNeshi mentioned this pull request Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SovereignAndrey SovereignAndrey SovereignAndrey approved these changes

@jp-mariano jp-mariano Awaiting requested review from jp-mariano

Assignees

@0xNeshi 0xNeshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Charity Registration: Refactor RegistrationStatus according to new design
2 participants
@0xNeshi @SovereignAndrey