Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullReferenceException in CssOriginValue when using transform-origin: bottom #161

Closed
5 tasks done
meziantou opened this issue Feb 26, 2024 · 3 comments · Fixed by #162
Closed
5 tasks done

NullReferenceException in CssOriginValue when using transform-origin: bottom #161

meziantou opened this issue Feb 26, 2024 · 3 comments · Fixed by #162
Labels
Milestone

Comments

@meziantou
Copy link
Contributor

Prerequisites

  • Can you reproduce the problem in a MWE?
  • Are you running the latest version of AngleSharp.Css?
  • Did you check the FAQs to see if that helps you?
  • Are you reporting to the correct repository? (there are multiple AngleSharp libraries, e.g., AngleSharp.Xml for Xml support)
  • Did you perform a search in the issues?

Description

Sorry, I don't have a MWE yet. I tried to strip down the code, the CssOriginValue can have null _z for transform-origin: bottom. So, there is a NullReferenceException in the compute method:

image

I'll try to create an MWE tomorrow if needed.

Steps to Reproduce

I will try to create a repro tomorrow

Expected Behavior

No exception

Actual Behavior

NullReferenceException

Possible Solution / Known Workarounds

No response

@meziantou meziantou added the bug label Feb 26, 2024
@FlorianRappl
Copy link
Contributor

I don't think an MWE is needed. In all three cases we should use, e.g., z?.Compute(context). null is an expected value here.

@meziantou
Copy link
Contributor Author

Thanks for the feedback. I'll submit a fix today or later this week.

BTW, any plan to enable nullable reference types in this project?

@FlorianRappl
Copy link
Contributor

-> https://github.com/AngleSharp/AngleSharp.Css/tree/feature/nullable.

@FlorianRappl FlorianRappl added this to the v1.0 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants