Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows compatibility is broken since upgrade to globby@v11 #118

Closed
curvedriver opened this issue Oct 15, 2021 · 0 comments · Fixed by #156
Closed

windows compatibility is broken since upgrade to globby@v11 #118

curvedriver opened this issue Oct 15, 2021 · 0 comments · Fixed by #156

Comments

@curvedriver
Copy link
Contributor

curvedriver commented Oct 15, 2021

Hi,
the update of globby to version v11 #112 has broken the compatibility with windows.

The reason for that is a change of globby's transitive dependency fast-glob which requires a convertion of the Windows-style path to a Unix-style path.

Quote:

Recommendation fast-glob:
https://github.com/mrmlnc/fast-glob#how-to-write-patterns-on-windows

I just tried a quick and dirty fix on my machine and everything worked as expected if I replace all backslashes at the resolved path with the following regex.

defaultPackagesGlobs.map(glob => resolve(projectDir, glob, "package.json").replace(/\\/g, '/')),

Line: index.js#L89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant