Latest version number and proper failure is not guaranteed

[ghost]

One of our workflow run failed with the following error:

[ERROR] CUID#7 - Download aborted. URI=https://github.com/rclone/rclone/releases/download/null/rclone-null-osx-amd64.zip
Exception: [AbstractCommand.cc:351] errorCode=3 URI=https://github.com/rclone/rclone/releases/download/null/rclone-null-osx-amd64.zip
-> [HttpSkipResponseCommand.cc:219] errorCode=3 Resource not found

It seems to be that the error came from here, where for some reason the latest version was determined as null:

setup-rclone/scripts/download/macOS.sh

Line 2 in 260c6f9

version=$(curl -s https://api.github.com/repos/rclone/rclone/releases/latest | jq -r '.tag_name')

Maybe some additional check/retry logic could be implemented in case the version is not properly returned, to make the run more resilient.

This step also didn't fail (which it should have), even though it failed to install the tool. Additional check could be implemented for that too.

[AnimMouse]

It seems to be that the error came from here, where for some reason the latest version was determined as null:
Maybe some additional check/retry logic could be implemented in case the version is not properly returned, to make the run more resilient.

It seems like GitHub APIs goes down recently, I think if GitHub API goes down, then perhaps we shouldn't be using GitHub Actions, right?

This step also didn't fail (which it should have), even though it failed to install the tool. Additional check could be implemented for that too.

Thanks for reporting that bug, it seems like I forgot to add set -e in the script.

[ghost]

It seems like GitHub APIs goes down recently, I think if GitHub API goes down, then perhaps we shouldn't be using GitHub Actions, right?

Yes, I haven't mentioned it, but the issue happened at 22:35 UTC, and the outage finished at 17:40 UTC, so GitHub was officially fully functional.

[AnimMouse]

the issue happened at 22:35 UTC, and the outage finished at 17:40 UTC, so GitHub was officially fully functional.

With the recent incident on GitHub 3 days in a row due to their mySQL1 load, I think GitHub is still down during that time.

Update: I was wrong. #3

This bug has been solved on 6e5a0cb, and this action will now fail when it failed to install the tool. Thanks for your bug report.

[ghost]

Thank you as well!

[AnimMouse]

where for some reason the latest version was determined as null

#3