Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Ubuntu 18 build fix #30

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Ubuntu 18 build fix #30

merged 4 commits into from
Apr 7, 2023

Conversation

dimas1185
Copy link
Contributor

This is to address cdt build failure on Ubuntu 18 when adding antler-proj as a submodule

@ScottBailey ScottBailey self-requested a review April 7, 2023 12:41
@ScottBailey
Copy link
Contributor

ScottBailey commented Apr 7, 2023 •
edited
Loading

This is a review of https://github.com/larryk85/cturtle/tree/2c3e6ddd3a8df40503001c9b3e0b6777e7e7af23 to https://github.com/dimas1185/cturtle/tree/3c310a67da7a4900f7c02de0effcb01ef41d501e.

ScottBailey
ScottBailey approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@ScottBailey ScottBailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ScottBailey ScottBailey requested a review from jolly-fellow April 7, 2023 13:18
@dimas1185 dimas1185 merged commit 436fedd into main Apr 7, 2023
@dimas1185 dimas1185 deleted the ubuntu-18-fix branch April 7, 2023 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ScottBailey ScottBailey ScottBailey approved these changes

@jolly-fellow jolly-fellow jolly-fellow approved these changes

Assignees

@dimas1185 dimas1185

Labels
None yet
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimas1185 @ScottBailey @jolly-fellow