Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables with name typed primary key not supported #97

Closed
nathanielhourt opened this issue Jan 27, 2023 · 1 comment · Fixed by #98
Closed

Tables with name typed primary key not supported #97

nathanielhourt opened this issue Jan 27, 2023 · 1 comment · Fixed by #98
Assignees
@dimas1185
Labels
👍 lgtm

Comments

@nathanielhourt
Copy link
Contributor

I have contracts which use name as the type of the primary key in several of their tables. This exact use case is historically the cause for the name type to have been envisioned and created in the first place. Even the EOSIO core contracts made extensive use of this pattern, albeit, by bending over backward to protect the CDT templates from the true type of the key...

Well that's just a bunch of silliness! Updating the templates to handle name typed primary keys is trivial, so why not just solve the problem once and have it go away, rather than adding complexity to every other contract?
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 27, 2023
@nathanielhourt nathanielhourt mentioned this issue Jan 27, 2023
Merged
2 tasks
@nathanielhourt
Copy link
Contributor Author

Hi... Is there anything I can do to help this issue move through triage and get my patch reviewed? It would be a big help for logistics on my end if this were resolved upstream so I don't have to maintain my own fork downstream.

@nathanielhourt nathanielhourt mentioned this issue Feb 26, 2023
Closed
@stephenpdeos stephenpdeos moved this from Todo to Awaiting Review in Team Backlog Mar 15, 2023
nathanielhourt added a commit to dapp-protocols/leap-cdt that referenced this issue Mar 20, 2023
@nathanielhourt
Ref AntelopeIO#97/AntelopeIO#98: Add unit test
faa9747 
Create a unit test for a table with a name primary key. The new test
fails to build before the commits in PReq AntelopeIO#98, but passes when those
commits are included.
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Mar 20, 2023
ScottBailey added a commit that referenced this issue Mar 20, 2023
@ScottBailey
Merge pull request #98 from dapp-protocols/fix-name-pk
3d14a67 
Resolve #97: Allow `name` typed primary keys
dimas1185 pushed a commit that referenced this issue Jun 8, 2023
@nathanielhourt @dimas1185
Ref #97/#98: Add unit test
732f83e 
Create a unit test for a table with a name primary key. The new test
fails to build before the commits in PReq #98, but passes when those
commits are included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimas1185 dimas1185

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #97: Allow name typed primary keys dapp-protocols/leap-cdt
5 participants
@nathanielhourt @larryk85 @dimas1185 @stephenpdeos @enf-ci-bot