Add extended_asset operators and unit tests. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
reviewed
Mar 22, 2023
greg7mdp
approved these changes
Mar 23, 2023
dimas1185
approved these changes
Mar 24, 2023
larryk85
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This change brings parity between
assetandextended_assetfor operators.Closes #105.
Brief doxygen comments for some comparison operators were made more specific.
API Changes
These
extended_assetoperators were added:extended_asset& operator*=(int64_t)extended_asset operator*(const extended_asset&, int64_t)extended_asset operator*(int64_t, const extended_asset&)int64_t operator/(const extended_asset&, const extended_asset&)extended_asset& operator/=( int64_t )extended_asset operator/( const extended_asset&, int64_t )This is an addition only, so no existing code should be impacted.
Documentation Additions
Test Additions
extended_asset unit tests were updated for the new operators.