[3.0] fix inconsistency in ABI generated for map #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Resolve #34.
Please see #34 for detailed problem description and solution discussion.
Previously,
map
ABI was a pair ofkey
andvalue
. If apair
's component types were the same as amap
, depending on the order of map and pair definition, different ABIs for pair were generated.For example, before the fix,
pair_int32_int64
were different depending onmy_map
was defined before or aftermy_pair
:generates
generates
After the fix, both produce the same ABI for
pair_int32_int64
In addition, Reference Contracts https://github.com/AntelopeIO/reference-contracts were tested against the new CDT and CDT 3.0.0, ABIs generated by both CDTs were the same.
API Changes
Documentation Additions