[main] Fracture Data Segments #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 2, 2022 18:33
…t into larryk85/fix_data_segments
linh2931
reviewed
Oct 3, 2022
No it will be just in |
linh2931
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The old way of partitioning the data segments had a few problems. 1) Some segments could become very large and fail set code on Antelope. 2) There were plenty of places where spans of zeros could be eliminated from the segments.
This PR allows for a new optimization to run on the data segments that will repartition the data segments with fracturing occurring at 1024 bytes maximum and when lengths of spans of zeros are present.
API Changes
Documentation Additions