Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename existing block_header_state and block_state to block_header_state_legacy and block_state_legacy #1940

Closed
linh2931 opened this issue Nov 30, 2023 · 2 comments · Fixed by #1951 or #1983
Closed

Rename existing block_header_state and block_state to block_header_state_legacy and block_state_legacy #1940

linh2931 opened this issue Nov 30, 2023 · 2 comments · Fixed by #1951 or #1983
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Leap v6.0.0-rc1

Comments

@linh2931
Copy link
Member

linh2931 commented Nov 30, 2023 •
edited by arhag
Loading

  • Rename existing structs block_header_state to block_header_state_legacy, block_state to block_state_lagacy;
  • Change block_header_state.{hpp,cpp} to block_header_state_legacy.{hpp,cpp} and change block_state.{hpp,cpp} to block_state_legacy.{hpp,cpp}.

There should be no functional changes to the behavior of Leap. Snapshots should still work without any version bump required.

This should target main. This is needed in preparation for the Instant Finality work.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Nov 30, 2023
@heifner
Copy link
Member

heifner commented Nov 30, 2023

The _legacy versions should match what is in 5.0 not hotstuff_integration branch.

@arhag arhag mentioned this issue Nov 30, 2023
Closed
@arhag arhag added 👍 lgtm and removed triage labels Nov 30, 2023
@arhag arhag mentioned this issue Nov 30, 2023
Closed
@arhag arhag changed the title IF: Unification: Rename existing block_header_state and block_state to block_header_state_legacy and block_state_lagacy IF: Unification: Rename existing block_header_state and block_state to block_header_state_legacy and block_state_legacy Nov 30, 2023
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Nov 30, 2023
@linh2931 linh2931 mentioned this issue Dec 1, 2023
Closed
@heifner heifner linked a pull request Dec 1, 2023 that will close this issue
IF: Rename existing block_header_state and block_state to block_header_state_legacy and block_state_legacy #1947
Closed
@arhag arhag changed the title IF: Unification: Rename existing block_header_state and block_state to block_header_state_legacy and block_state_legacy Rename existing block_header_state and block_state to block_header_state_legacy and block_state_legacy Dec 4, 2023
@arhag arhag added this to the Leap v6.0.0-rc1 milestone Dec 4, 2023
@linh2931 linh2931 mentioned this issue Dec 5, 2023
Merged
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Dec 5, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Dec 6, 2023
@linh2931 linh2931 moved this from Done to In Progress in Team Backlog Dec 11, 2023
@linh2931
Copy link
Member Author

Reopen to rename pending_block_header_state to pending_block_header_state_legacy

@linh2931 linh2931 reopened this Dec 11, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Todo in Team Backlog Dec 11, 2023
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Dec 11, 2023
@linh2931 linh2931 mentioned this issue Dec 12, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
4 participants
@heifner @arhag @linh2931 @enf-ci-bot