From aa6c88cacf788e2f9324bec6739cc125ba28ca75 Mon Sep 17 00:00:00 2001
From: Lin Huang <lin.huang@eosnetwork.com>
Date: Mon, 29 Apr 2024 17:09:48 -0400
Subject: [PATCH] Remove almost empty instant_finality_extension.cpp

---
 libraries/chain/CMakeLists.txt                      |  1 -
 .../chain/finality/instant_finality_extension.cpp   | 13 -------------
 .../chain/finality/instant_finality_extension.hpp   |  6 +++++-
 3 files changed, 5 insertions(+), 15 deletions(-)
 delete mode 100644 libraries/chain/finality/instant_finality_extension.cpp

diff --git a/libraries/chain/CMakeLists.txt b/libraries/chain/CMakeLists.txt
index e1cc1c4ba5..2a47d89cfa 100644
--- a/libraries/chain/CMakeLists.txt
+++ b/libraries/chain/CMakeLists.txt
@@ -81,7 +81,6 @@ set(CHAIN_WEBASSEMBLY_SOURCES
 
 set(CHAIN_FINALITY_SOURCES
         finality/finalizer.cpp
-        finality/instant_finality_extension.cpp
         finality/quorum_certificate.cpp
         finality/finality_core.cpp
 )
diff --git a/libraries/chain/finality/instant_finality_extension.cpp b/libraries/chain/finality/instant_finality_extension.cpp
deleted file mode 100644
index 6be58a039d..0000000000
--- a/libraries/chain/finality/instant_finality_extension.cpp
+++ /dev/null
@@ -1,13 +0,0 @@
-#include <eosio/chain/finality/instant_finality_extension.hpp>
-#include <eosio/chain/exceptions.hpp>
-
-namespace eosio::chain {
-
-#warning this file can be removed if no actual validation comes up after all design is complete
-   void instant_finality_extension::reflector_init() {
-      static_assert( fc::raw::has_feature_reflector_init_on_unpacked_reflected_types,
-                     "instant_finality_extension expects FC to support reflector_init" );
-      static_assert( extension_id() == 2, "instant_finality_extension extension id must be 2" );
-   }
-
-}  // eosio::chain
diff --git a/libraries/chain/include/eosio/chain/finality/instant_finality_extension.hpp b/libraries/chain/include/eosio/chain/finality/instant_finality_extension.hpp
index 7e3352afdc..3b78770a5b 100644
--- a/libraries/chain/include/eosio/chain/finality/instant_finality_extension.hpp
+++ b/libraries/chain/include/eosio/chain/finality/instant_finality_extension.hpp
@@ -19,7 +19,11 @@ struct instant_finality_extension : fc::reflect_init {
       new_proposer_policy(std::move(new_proposer_policy))
    {}
 
-   void reflector_init();
+   void reflector_init() const {
+      static_assert( fc::raw::has_feature_reflector_init_on_unpacked_reflected_types,
+                     "instant_finality_extension expects FC to support reflector_init" );
+      static_assert( extension_id() == 2, "instant_finality_extension extension id must be 2" );
+   }
 
    qc_claim_t                         qc_claim;
    std::optional<finalizer_policy>    new_finalizer_policy;