Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

different signedness comparison warning in nonprune_to_prune_on_start test #1191

Closed
linh2931 opened this issue Feb 20, 2025 · 1 comment · Fixed by #1193
Closed

different signedness comparison warning in nonprune_to_prune_on_start test #1191

linh2931 opened this issue Feb 20, 2025 · 1 comment · Fixed by #1193
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Spring v1.1.1

Comments

@linh2931
Copy link
Member

linh2931 commented Feb 20, 2025 •
edited
Loading

Matt suggested fixing on release/1.1 branch. It's a low risk to fix the warning on release/1.1 branch and makes compile cleaner.

tests/block_log.cpp:655:26: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
  655 |    for(unsigned i = 0; i < prune_blocks*3; ++i)
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Feb 20, 2025
@linh2931 linh2931 added 👍 lgtm and removed triage labels Feb 20, 2025
@linh2931 linh2931 self-assigned this Feb 20, 2025
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Feb 20, 2025
@linh2931 linh2931 added this to the Spring v1.1.1 milestone Feb 20, 2025
@linh2931 linh2931 mentioned this issue Feb 20, 2025
Merged
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Feb 20, 2025
@linh2931 linh2931 mentioned this issue Feb 20, 2025
Merged
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Feb 20, 2025
@ericpassmore
Copy link
Contributor

Note:start
category: Chores
component: Internal
summary: Fix signedness comparison warning in tests
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Status: Done
Milestone
Spring v1.1.1
3 participants
@ericpassmore @linh2931 @enf-ci-bot