Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote logging #215

Closed
heifner opened this issue May 28, 2024 · 4 comments
Closed

Vote logging #215

heifner opened this issue May 28, 2024 · 4 comments
Labels
triage

Comments

@heifner
Copy link
Member

heifner commented May 28, 2024

Currently vote logger logs missing votes in a QC of a block header.

  • Add log indication of the qc block_num either always or only when the block_num is not the previous block.
  • Add log indication when a block does not contain a qc.
@greg7mdp greg7mdp self-assigned this Jun 3, 2024
@heifner
Copy link
Member Author

heifner commented Jun 3, 2024

  • Would be nice to log the finalizer description instead of having to look up the bls public key to determine who the finalizer key belongs to.
  • Should have a log near the beginning of when a vote message comes in so we can easily tell how long an individual vote takes to process.

@greg7mdp greg7mdp removed their assignment Jun 3, 2024
@arhag
Copy link
Member

arhag commented Jun 5, 2024

Related: #226

@heifner
Copy link
Member Author

heifner commented Jun 7, 2024

Related logging fix, during a sync the log is spammed with:

info  2024-06-07T13:02:22.443 nodeos    controller.cpp:4069           operator()           ] applying 19 fork db blocks from 2339102:0023b11ec16b9f8fd993e5c93b3303464099d8472ae34cd6519eb45f9642ad5c to 2339120:0023b130b4197262958ffb5bf82b50c4ee053b59b724b24d2b1ec65beabdcb8b

@heifner
Copy link
Member Author

heifner commented Aug 9, 2024 •
edited
Loading

I believe we have incorporated the logging desired/known at this time.

@heifner heifner closed this as completed Aug 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@greg7mdp @heifner @arhag @enf-ci-bot