Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ship refactor followup: batch blocks for sending #223

Closed
spoonincode opened this issue Jun 3, 2024 · 1 comment
Closed

ship refactor followup: batch blocks for sending #223

spoonincode opened this issue Jun 3, 2024 · 1 comment

Comments

@spoonincode
Copy link
Member

Currently ship operates by deciding what block to send on the main thread, jumping to the ship thread to actually send that block, and then jumping back to the main thread again to decide what block to send, repeat.

It should be quite straightforward to instead of deciding what block to send, decide what blocks to send (up to some reasonable limit). Batching in this manner will reduce the frequency of taking the round trip to the separate ship thread when a ship client is in catchup.

@bhazzard
Copy link

In absence of a way to monitor the potential performance impact of this change, we'll opt not to tackle this at this time.

@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Aug 22, 2024
@bhazzard bhazzard removed the triage label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants