Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ship abi.cpp's finality_data doesn't match up with finality_data_t #243

Closed
spoonincode opened this issue Jun 6, 2024 · 1 comment · Fixed by #251
Closed

ship abi.cpp's finality_data doesn't match up with finality_data_t #243

spoonincode opened this issue Jun 6, 2024 · 1 comment · Fixed by #251
Assignees

Comments

@spoonincode
Copy link
Member

struct finality_data_t {
uint32_t major_version{light_header_protocol_version_major};
uint32_t minor_version{light_header_protocol_version_minor};
uint32_t active_finalizer_policy_generation{0};
uint32_t final_on_strong_qc_block_num{0};
digest_type action_mroot{};
digest_type base_digest{};
std::optional<finalizer_policy> proposed_finalizer_policy; // finalizer policy, if proposed in the block
};

vs
"name": "finality_data", "fields": [
{ "name": "major_version", "type": "uint32" },
{ "name": "minor_version", "type": "uint32" },
{ "name": "active_finalizer_policy_generation", "type": "uint32" },
{ "name": "action_mroot", "type": "checksum256" },
{ "name": "base_digest", "type": "checksum256" }
]

@greg7mdp
Copy link
Contributor

greg7mdp commented Jun 6, 2024

That was missed in #124 and #220.

@spoonincode spoonincode self-assigned this Jun 7, 2024
@spoonincode spoonincode moved this from Todo to In Progress in Team Backlog Jun 7, 2024
@spoonincode spoonincode moved this from In Progress to Awaiting Review in Team Backlog Jun 7, 2024
@spoonincode spoonincode moved this from Awaiting Review to Reviewer Approved in Team Backlog Jun 7, 2024
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Team Backlog Jun 7, 2024
@BenjaminGormanPMP BenjaminGormanPMP added this to the Spring v1.0.0-rc1 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants