Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerformanceHarness version roll back ambiguity #49

Closed
spoonincode opened this issue Apr 18, 2024 · 1 comment · Fixed by #953
Closed

PerformanceHarness version roll back ambiguity #49

spoonincode opened this issue Apr 18, 2024 · 1 comment · Fixed by #953
Assignees

Comments

@spoonincode
Copy link
Member

PerformanceHarness configures itself differently based on what nodeos --full-version returns. Its behavior is altered if the version begins with v2 or v4 with the assumption if it's not one of those versions it must be the "latest". So for spring v1 this code still does what is expected ("latest"), but spring v2 will not follow the expected path. Examples,

if "v2" in self.nodeosVers:
validationNodeSpecificNodeosStr += '--plugin eosio::history_api_plugin --filter-on "*" '
else:
#If prodsEnableTraceApi, then Cluster configures all nodes with trace_api_plugin so no need to duplicate here

if "v4" in self.nodeosVers:
apiNodeSpecificNodeosStr += f"--read-only-threads {self.apiNodesReadOnlyThreadCount} "
if apiNodeSpecificNodeosStr:
self.specificExtraNodeosArgs.update({f"{nodeId}" : apiNodeSpecificNodeosStr for nodeId in self._apiNodeIds})

@bhazzard
Copy link

For now let's remove this code handling of versions.

We only care about performance relative to the previous major version. One way to do that is to run the performance harness independently on each major version. If the new performance harness has changes to tests / metrics that aren't backported, that approach won't work. In that case we may need to reintroduce only for the previous supported version.

Similar issue: #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants