You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PerformanceHarness configures itself differently based on what nodeos --full-version returns. Its behavior is altered if the version begins with v2 or v4 with the assumption if it's not one of those versions it must be the "latest". So for spring v1 this code still does what is expected ("latest"), but spring v2 will not follow the expected path. Examples,
For now let's remove this code handling of versions.
We only care about performance relative to the previous major version. One way to do that is to run the performance harness independently on each major version. If the new performance harness has changes to tests / metrics that aren't backported, that approach won't work. In that case we may need to reintroduce only for the previous supported version.
PerformanceHarness
configures itself differently based on whatnodeos --full-version
returns. Its behavior is altered if the version begins withv2
orv4
with the assumption if it's not one of those versions it must be the "latest". So for spring v1 this code still does what is expected ("latest"), but spring v2 will not follow the expected path. Examples,spring/tests/PerformanceHarness/performance_test_basic.py
Lines 128 to 131 in bef48a2
spring/tests/PerformanceHarness/performance_test_basic.py
Lines 144 to 147 in bef48a2
The text was updated successfully, but these errors were encountered: