Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2pNet needs error handling (create exceptions) #14

Open
jimkberry opened this issue Oct 19, 2021 · 0 comments
Open

P2pNet needs error handling (create exceptions) #14

jimkberry opened this issue Oct 19, 2021 · 0 comments
Assignees
Labels
Sys: P2pNet Type: Tech Debt Servicing technical debt

Comments

@jimkberry
Copy link
Member

Currently there is no consistent way to deal with non-crash errors that occur.

Letting the calling code deal with them is a fine thing, but the caller needs to be informed. Seems like the right thing to do here is to create a P2pNetException class along with specific subclasses and just raise 'em and let the caller sort it out,.

@jimkberry jimkberry added Type: Tech Debt Servicing technical debt Sys: P2pNet labels Oct 19, 2021
@jimkberry jimkberry self-assigned this Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sys: P2pNet Type: Tech Debt Servicing technical debt
Projects
None yet
Development

No branches or pull requests

1 participant