Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the build targets for V8 #1534

Closed
martintmk opened this issue Aug 31, 2023 · 3 comments · Fixed by #1572
Closed

Refine the build targets for V8 #1534

martintmk opened this issue Aug 31, 2023 · 3 comments · Fixed by #1572
Labels
v8 Issues related to the new version 8 of the Polly library.
Milestone

Comments

@martintmk
Copy link
Contributor

Looking on our build targets in #1360 it looks like:

<TargetFrameworks>net8.0;net7.0;net6.0;netstandard2.0;net472;net462</TargetFrameworks>

Can we trim these down?

For example:

  • Drop net472 (not necessary since we have net462)
  • Drop net6.0 and net7.0 in favor of netcoreapp3.1?
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 31, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 31, 2023
@martincostello
Copy link
Member

My thoughts:

  • I thought net472 was preferred for proper netstandard2.0 compatibility because it wasn't quite right in earlier versions?
  • netcoreapp3.1 is out of support now and has less APIs than are available in net6.0 and net7.0, so if we were going to drop anything I'd just drop net7.0 (unless there's some APIs were using from it that help performance).
  • I think we want to keep net472;net462 for backwards compatibility for v7 users still on .NET Framework.

I think that would leave us with:

  • For 8.0.0: net6.0;netstandard2.0;net472;net462
  • For 8.x.x: net8.0;net6.0;netstandard2.0;net472;net462

I think that's a net change of just dropping net7.0, but we could drop net6.0 too if there's nothing useful we're using from it.

@martintmk
Copy link
Contributor Author

I think that's a net change of just dropping net7.0, but we could drop net6.0 too if there's nothing useful we're using from it.

I believe we are using CancellationTokenSource.TryReset that's there from .NET 6.0.

I thought net472 was preferred for proper netstandard2.0 compatibility because it wasn't quite right in earlier versions?

True.

Just brainstorming, based on this all these targets are kinda usefull :)

@martincostello
Copy link
Member

Maybe we just drop net7.0 if we're not actively using anything from it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants