Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting max retry delay when using standard backoff types #1605

Closed
juraj-blazek opened this issue Sep 21, 2023 · 1 comment · Fixed by #1620
Closed

Limiting max retry delay when using standard backoff types #1605

juraj-blazek opened this issue Sep 21, 2023 · 1 comment · Fixed by #1620
Labels
v8 Issues related to the new version 8 of the Polly library.
Milestone

Comments

@juraj-blazek
Copy link

With current API it's not possible to limit max retry delay while using built-in backoff types.

We have a scenario where we infinitely retry failing background operations until recovery. Once the failures start, we want to backoff exponentially using the built-in generators, but eventually limit the calculated delay to some maximum value.

Consider adding TimeSpan MaxRetryDelay? property to the retry options that will cap the generated delay value. It might be applicable both for built-in and externally provided delay generators.

cc @martintmk

@martintmk
Copy link
Contributor

I think this is a valid scenario. The changes should be relatively small so we can still squeeze this into v8.

Minor comments only:

  • MaxRetryDelay should be MaxDelay - because we have the Delay property
  • Maybe not apply the cap on external generators? (as the generation is fully under their control)

cc @martincostello

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 21, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 21, 2023
@github-project-automation github-project-automation bot moved this to Done in Polly v8 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants