Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "run app" logic to shared module. #44

Open
TheAssassin opened this issue Nov 15, 2017 · 4 comments
Open

Move "run app" logic to shared module. #44

TheAssassin opened this issue Nov 15, 2017 · 4 comments

Comments

@TheAssassin
Copy link
Member

Currently, the "run" logic is available in the GUI application only, but it might be a good idea to move it out to a module shared between all applications. It might even make sense to move it to the Updater class, to allow other libraries to make use of its functionality.

Related to #31.

@probonopd
Copy link
Member

Note that just executing a binary produces different results (at least in GNOME) compared to launching an application via its desktop file or via the menu:

  • For applications that ship an icon but do not actively set the icon on their main window, the application icon will only show up in the dock if the application was launched via its desktop file or via the menu
  • Also, the context menu items in the dock are only available if the application was launched via its desktop file or via the menu

I had written some code that emulates the "proper" way of launching something through its desktop file some time back, AppImage/AppImageKit#174 (comment). This is overkill for appimageupdatetool but we may want to consider this for AppImageUpdate.

Low priority though.

@TheAssassin
Copy link
Member Author

Hm, the problem is that code links to glib, which I could successfully avoid as a dependency so far. First of all, the "run app" code has to be refactored out, however. If we add this behavior, it should probably not be part of libappimageupdate but the standalone applications.

@probonopd
Copy link
Member

That is true. Ideally this would be invoked by runtime when running an AppImage. And indeed one would need to look deeper than this to understand how to re-create this without additional dependencies such as glib. So indeed probably out of scope here.

@TheAssassin
Copy link
Member Author

@probonopd well we could always make a separate executable with that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants