-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIREFOX 58] - some @media rules get ignored [but work fine Firefox 57 and 59] #101
Comments
Interesting. I am on 58 now and using v1.5.0 of your files and everything appears the same as it did with 57 (Windows 7 Pro with Classic skin). I'll probably leave it as is. Anyway, thanks for your work. My current config is here: http://www.markheadrick.com/firefox/firefox_config.php#appearance |
Only some features broke or cause glitches. Windows Classic Theme
Windows 10
|
Do I understand this right that now after publication of version 59 all these fixes can safely be disabled? And could also be removed from new releases? |
Yes, all Fx58 fixes are not required by Fx59+. |
@mazesy |
@Aris-t2 , OK. I admire your commitment moreover with perpetual Firefox internal modifications. I also really -- I mean, really -- appreciate your work, I use it extensively. Concerning what I had above mentioned concerning a setting which would no longer work with FF59, it didn't include @media rules (your answer did though), I've found an old CSS line I used with Stylish with previous to 57 Firefox versions. It's basically basic but does the job, mine anyhow as I was aiming to change only nav-bar and PersonalToolbar background colors ...
That's all I wanted. For the rest I rely on CustomCSSforFx |
If you are using this projects full release, you can configure everything inside /config/ folders files incl. toolbar colors (see color_variables.css). Your code most likely is not able to override default code set by this project. Make sure you are using the latest version (1.7.6). |
Firefox 57/58 support dropped with the releases of 1.7.7 and 1.7.8. |
Firefox 58 (release, beta, Nightly) ignores code as shown in this example
Some of this projects features rely on correct OS or theme detection resulting in not applying any code part of these @media rules when loaded through userChrome.css/userContent.css.
A filed bug report can be found here: https://bugzilla.mozilla.org/show_bug.cgi?id=1431933
I can confirm the issue is not present in Firefox 59 beta. I suggest to skip Firefox 58 and directly go to 59 beta 3+, if you are affected by this issue.
This bug might not get fixed, because a developers answer to another "userChrome" issue was
https://bugzilla.mozilla.org/show_bug.cgi?id=1400542#c1
EDIT
This projects version 1.5.8 contains additional fixed files for Firefox 58. They have to be enabled manually depending on the options used.
EDIT (2018-03-08)
After Firefox 59 release this project will drop support for Firefox 58 (57 should still work fine, but why use it?).
The text was updated successfully, but these errors were encountered: