-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when executing Kismet Event Commands #68
Comments
Hi Dario, thanks for reporting this. We think that the implementation in
We will do some further checks for other unwanted side-effects but are confident that this would solve the problem. |
Hi Peter, I have UArticyBaseObject::GetWorld() as in the original code: And UArticyPackage::GetWorld() as you proposed: |
Hi Dario, thanks for the further information. As far as I can tell, your workaround to always return nullptr should be fine for now. It seems like that overriding GetWorld() in our plugin is no longer needed. A few quick tests confirmed this. Probably, removing GetWorld() will be our solution. But won’t publish the change until the new year. |
Hello,
we have encountered a crash on UE 4.27.1 when executing a Kismet Event Command.
We are using v1.3.1 of the importer.
It happens in both our project and the ManiacMansion demo.
Repro steps:
From what I understand, the ArticyPackage needs to provide an implementation of UWorld* GetWorld() const;
This is blocking other people on the team from using Kismet Event Commands which is a problem.
I have avoided the crash locally by changing the implementation of UArticyBaseObject::GetWorld() to always return nullptr, but this is clearly not an actual fix and I have no idea how many things it might be breaking in Articy.
What should the actual implementation of UArticyPackage::GetWorld() be?
Thanks,
Dario @ YellowBrickGames
.
The text was updated successfully, but these errors were encountered: