Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a subtle bug where the present, paused on node is executed twice, once upon arrival, and once upon leaving.
This is caused by the logic in our
UpdateAvailableBranches
code. It always adds the current node to the start of every available branch. When advancing along a branch, we execute each node in the its path. Since the current node was previously the last node in the path of a branch, and is now the first node in the next branch, it's executed twice.Normally, this was not a problem since only
OutputPin
andInstruction
nodes have an implementation ofExecute
and usuallyInstruction
nodes are not paused at. However, if the user does setInstruction
in their Pause On setting on the flow player, they'll see this bug.The original behavior of adding the present node to the start of each branch is maintained whenever we reset the current cursor, as we presumably want to make sure we execute the node we begin at.