Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Matrix Property #56

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Add Support for Matrix Property #56

merged 2 commits into from
Sep 30, 2021

Conversation

brwarner
Copy link
Contributor

Adding support for the new Matrix property in Articy:draft's JSON export. This property combines the translation, rotation, and scale of location objects like Zones, Text, and Images.

The 3x3 2D JSON matrix is converted into a 4x4 Unreal FMatrix that can operate on 2D and 3D vectors alike.

@brwarner brwarner added the 1.3.1 label Sep 28, 2021
@brwarner brwarner self-assigned this Sep 28, 2021
@brwarner
Copy link
Contributor Author

There's some discrepancies with the rotations done via the imported matricies and ones I generate on my own from the same angles. Not sure if this is an issue with the Articy export or my importer. Will have to take a closer look first.

@brwarner
Copy link
Contributor Author

Tested with multiple rotation values and with both translation/scale. Everything matches identical transformations computed by Unreal.

@brwarner brwarner marked this pull request as ready for review September 30, 2021 14:18
@brwarner brwarner merged commit 502d633 into development Sep 30, 2021
@brwarner brwarner deleted the matrix-property branch September 30, 2021 14:21
@brwarner brwarner added this to the v1.3.1 milestone Oct 8, 2021
@brwarner brwarner removed the 1.3.1 label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant