From b7c2d2c3331b61706c9d56e80b3a1ab3708e542e Mon Sep 17 00:00:00 2001
From: childish-sambino <sharrison@twilio.com>
Date: Thu, 21 Nov 2019 10:19:23 -0600
Subject: [PATCH] fix: add keytar sanity-check during install (#75)

---
 Makefile                       | 2 +-
 src/services/secure-storage.js | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index bac73827..c7982b93 100644
--- a/Makefile
+++ b/Makefile
@@ -4,7 +4,7 @@ githooks:
 	ln -sf ../../githooks/pre-commit .git/hooks/pre-commit
 
 install: githooks
-	npm install
+	npm install --no-optional
 
 test:
 	npm test
diff --git a/src/services/secure-storage.js b/src/services/secure-storage.js
index b1b9b075..130ea75c 100644
--- a/src/services/secure-storage.js
+++ b/src/services/secure-storage.js
@@ -1,6 +1,7 @@
 const { CLI_NAME } = require('./config');
 const { TwilioCliError } = require('./error');
 const { HELP_ENVIRONMENT_VARIABLES } = require('./messaging/help-messages');
+const { logger } = require('./messaging/logging');
 
 const STORAGE_LOCATIONS = {
   KEYCHAIN: 'keychain',
@@ -25,7 +26,11 @@ class SecureStorage {
     if (!this.keytar) {
       try {
         this.keytar = await this.command.install('keytar');
+
+        // Also sanity-check that we can retrieve passwords (just use a dummy profile ID).
+        await this.keytar.getPassword(CLI_NAME, CLI_NAME);
       } catch (error) {
+        logger.debug(`Error loading keytar: ${error}`);
         // If we can't load up keytar, tell the user that maybe they should just stick to env vars.
         throw new TwilioCliError('Secure credential storage failed to load.\n\n' + HELP_ENVIRONMENT_VARIABLES);
       }