Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement for ATMODAT4.0: validate URLs #124

Open
atmodatcode opened this issue Apr 12, 2022 · 1 comment
Open

enhancement for ATMODAT4.0: validate URLs #124

atmodatcode opened this issue Apr 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@atmodatcode
Copy link
Member

This is a piece of code that we could integrate in a future checker enhancement that consists of checking the validity of the metadata URLs.

`from IPython.display import display
import requests

url="https://cera-www.dkrz.de/WDCC/ui/cerasearch/entry?acronym=LambWTyRSetAndGaleDaysOverTheNo"
try:
response = requests.get(url)
except:
print("Not a valid url!")
else:
if response.status_code != 200:
print("Not a valid url!")
else:
print('url is valid!')`

@atmodatcode atmodatcode added the enhancement New feature or request label Apr 12, 2022
@jkretz
Copy link
Collaborator

jkretz commented May 20, 2022

I set up the functionality for this check in the orcid_check branch. As long as it is not in the ATMODAT standard, I am not sure if we should merge it. To activate those checks, they have to be added to the atmodat_standard_checks.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants