Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] deprecate AtmosphereResouce.setBroadcaster() #1091

Closed
freedom1989 opened this issue May 15, 2013 · 1 comment
Closed

[Enhancement] deprecate AtmosphereResouce.setBroadcaster() #1091

freedom1989 opened this issue May 15, 2013 · 1 comment

Comments

@freedom1989
Copy link
Contributor

As far as I know, one AtmosphereResource can be added into several Broadcasters.
It is confused for someone else to understand the function of AtmosphereResource#setBroadcaster() method.
It always make me think which broadcaster I should pass into the method...
I think that having Broadcaster#addResource() is enough.

For backward compatibility, we can just add @deprecated annotation on the method.
@jfarcand
Copy link
Member

jfarcand commented Jul 8, 2013

No change for now, so closing.

@jfarcand jfarcand closed this as completed Jul 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfarcand @freedom1989