Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsisten use of BroadcasterFactory in AtmosphereFramework #430

Closed
pierreh opened this issue Jun 22, 2012 · 1 comment
Closed

Inconsisten use of BroadcasterFactory in AtmosphereFramework #430

pierreh opened this issue Jun 22, 2012 · 1 comment

Comments

@pierreh
Copy link

pierreh commented Jun 22, 2012

In AtmosphereFramework.java a BroadcasterFactory is determined and created and set in the the field broadcasterFactory. However this field is not consistently used. For instance in doCometSupport :
req.setAttribute(BROADCASTER_FACTORY, BroadcasterFactory.getDefault());

@pierreh
Copy link
Author

pierreh commented Jun 22, 2012

Not sure if this is an issue because the BroadcasterFactory.factory is updated through the AtmosphereFramework. However perhaps it is best to keep a consistent location from where to access it.

@jfarcand jfarcand closed this as completed Nov 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants