From 44721e668e0147a259a483a0650155a21df49c1b Mon Sep 17 00:00:00 2001 From: TheR1sing3un <87409330+TheR1sing3un@users.noreply.github.com> Date: Wed, 6 Sep 2023 03:18:37 -0500 Subject: [PATCH] refactor(s3): remove useless `sourceObjectIds` in `CommitWALObjectRequest` (#65) 1. remove useless `sourceObjectIds` in `CommitWALObjectRequest` Signed-off-by: TheR1sing3un --- .../resources/common/message/CommitWALObjectRequest.json | 6 ------ core/src/main/scala/kafka/log/s3/objects/StreamObject.java | 3 +-- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/clients/src/main/resources/common/message/CommitWALObjectRequest.json b/clients/src/main/resources/common/message/CommitWALObjectRequest.json index 48db9f3efc..b19f501f4a 100644 --- a/clients/src/main/resources/common/message/CommitWALObjectRequest.json +++ b/clients/src/main/resources/common/message/CommitWALObjectRequest.json @@ -118,12 +118,6 @@ "type": "int64", "versions": "0+", "about": "The end offset of the stream range" - }, - { - "name": "sourceObjectIds", - "type": "[]int64", - "versions": "0+", - "about": "The IDs of the source S3 objects" } ] }, diff --git a/core/src/main/scala/kafka/log/s3/objects/StreamObject.java b/core/src/main/scala/kafka/log/s3/objects/StreamObject.java index c3c4a05036..79966d12f8 100644 --- a/core/src/main/scala/kafka/log/s3/objects/StreamObject.java +++ b/core/src/main/scala/kafka/log/s3/objects/StreamObject.java @@ -86,8 +86,7 @@ public CommitWALObjectRequestData.StreamObject toStreamObjectInRequest() { .setObjectId(objectId) .setObjectSize(objectSize) .setStartOffset(startOffset) - .setEndOffset(endOffset) - .setSourceObjectIds(sourceObjectIds); + .setEndOffset(endOffset); } @Override