-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One click lightbox option for all single images #19562
Comments
More from the person suggesting this -
As an example they gave the example of: https://www.xda-developers.com/android-12-app-ui-translation/ |
I'll mark this as "won't fix". As you mentioned, this is already an option today:
If one wanted this to apply to all images on their site, they could change the default link attachment settings for all images. While I have not tested this myself, something like this should help: |
👋 Hi @jeherve, I tried both methods that are listed there, but they didn't work. Then I tried the steps provided here but again no result. It looks like |
It worked well for me. When using this: add_action( 'after_setup_theme', 'my_new_default_image_settings' );
function my_new_default_image_settings() {
update_option( 'image_default_link_type', 'attachment' );
} Posts created after I added the snippet link to the attachment page by default, and Jetpack's Carousel is triggered. |
👋 Hi @jeherve, It didn't work when I added in
Could you please provide the steps? 🤔 My steps:I enabled the Carousel then I went to Appearance > Theme Editor (Twenty Twenty) > functions.php and used this:
As the next step, for testing, I went to post and clicked on a single image but it didn't open in the lightbox. |
Here is a quick screen recording, if that helps clarify things a bit: Screen.Recording.2021-04-23.at.9.43.24.mov |
👋 Hi @jeherve, thank you so much for the recording. 🤗 Here's what we found: If we add code in Can we do something that can change settings for all old posts/pages (including the old ones), or if we can add this feature in Jetpack? 🙂 3911676-zen |
No, that's most likely something you'd have to do on your own, either via a plugin or via a query that will edit all your posts. We don't typically modify post content in all your existing posts for you in Jetpack. |
Is your feature request related to a problem? Please describe.
In Jetpack, we have a one-click Carousel option that provides a full-screen photo browsing experience. But for a single image, users need to link the image with the attachment page to make a single image open in its own lightbox.
Describe the solution you'd like
Similar to the one-click Carousel option, we can provide a one-click lightbox option for all single images. This way users will not need to manually link all images with their attachment page to enable lightbox.
If we have any user who doesn't want the lightbox for all single images and wants this feature for only selected images, they can disable the one-click lightbox option and manually link selected images with their respective attachment page.
The text was updated successfully, but these errors were encountered: