Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WhatsApp Block: issues when removing child button block #25105

Open
nagpai opened this issue Jul 9, 2022 · 4 comments
Open

WhatsApp Block: issues when removing child button block #25105

nagpai opened this issue Jul 9, 2022 · 4 comments
Labels
[Block] Send a message Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@nagpai
Copy link

nagpai commented Jul 9, 2022

Quick summary

The WhatsApp button block creates a send message block with a WhatsApp button block nested within it.

When a user tries to delete the block it reappears on reload of editor. Because of the UI of gutenberg, users typically end up deleting the Button block and not the parent send message block that remains invisible. The whatsapp button gets added again

Steps to reproduce

  1. Create a new page or post
  2. Add WhatsApp block and save changes.
  3. Reload browser, and click and delete the whatsapp button. It removes the button. Save changes. There is no indication of the parent Send a message block being still active.
  4. Reload the browser, the button reappears.

Uploading whatsapp-bug.mov…

What you expected to happen

Ideal case - The parent Send a message block should get deleted when someone deletes the whatsapp button.

Next-to-ideal : Show a dummy block in editor that the Send message block is still present.

What actually happened

Described in the video and details above.

Context

36020401-hc

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

No response

Browser, operating system and other notes

MacOS - Vivaldi 5.3.2679.68

( happens across different browsers though )

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, difficult to implement

Workaround details

Use the list view and delete the parent Send a message block

@nagpai nagpai added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Jul 9, 2022
@Robertght Robertght transferred this issue from Automattic/wp-calypso Jul 15, 2022
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Jul 15, 2022
@Robertght
Copy link

📌 HOUSEKEEPING

  • Labels ✅
  • Priority ✅
  • Replicable on Core - Yes

📌 SCRUBBING

  • Tested on P2 - no
  • Tested on Simple ✅
  • Tested on AT ✅
  • Tested on Self-hosted ✅

📌 FINDINGS/SCREENSHOTS/VIDEO

Using the List view should help the users remove that block entirely.

📌 ACTIONS

  • Marked as Triaged for Quality Squad review
  • Transferred to XYZ external repo: link

📌 Message to Author

  • The video didn't upload, however, you can upload it here later if you want.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

Support References

  • 36020401-hc
  • 8226220-hc

@jeherve
Copy link
Member

jeherve commented Jul 15, 2022

Yup, that's the same issue indeed. I'll close the other one since there are more details here.

@jeherve jeherve changed the title WhatsApp button: Confusing UI WhatsApp Block: issues when removing child button block Jul 15, 2022
@jeherve jeherve added [Block] Send a message [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jul 15, 2022
@jeherve
Copy link
Member

jeherve commented Jul 15, 2022

Related: #24838

Additional info from #18104:


References:

  • 8226220-hc

this happens because you're deleting the child block, and not the parent block. Here is how I would go about it:

videopress.com/v/pYqlck4o

That's an annoying byproduct of parent / child blocks.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Send a message Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants