Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing / Social: update Twitter logo #32178

Closed
2 tasks
rw-ye opened this issue Jul 30, 2023 · 9 comments · Fixed by #33134
Closed
2 tasks

Sharing / Social: update Twitter logo #32178

rw-ye opened this issue Jul 30, 2023 · 9 comments · Fixed by #33134
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Extra Sidebar Widgets [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Sharing Post sharing, sharing buttons [Feature] Theme Tools [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin [Pri] Normal [Type] Janitorial

Comments

@rw-ye
Copy link

rw-ye commented Jul 30, 2023

What

Update the logo for Twitter to the new logo

Feature request from user: 6586135-zd-woothemes

Why

Twitter has recently updated its logo: https://techcrunch.com/2023/07/24/twitter-has-officially-changed-its-logo-to-x/

How

No response


Just adding a couple places where this appears; feel free to update with more (-cuemarie):

  • Social Icons block
  • Sharing Buttons
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6586135-zen
  • 7140561-zen
  • 7368162-zen
  • 7394377-zen

@cuemarie
Copy link

📌 ACTIONS

@cuemarie cuemarie added the [Feature] Sharing Post sharing, sharing buttons label Jul 31, 2023
@cuemarie cuemarie changed the title [Social Icons Block] Update Twitter logo Update Twitter logo - Sharing Buttons, Social icons block Jul 31, 2023
@cuemarie
Copy link

Noted on this internal discussion: p1690826399037819/1690812959.552119-slack-C029KQRGV

@jeherve
Copy link
Member

jeherve commented Aug 1, 2023

As far as I know, the new X logo is currently an interim logo, so we may want to wait until the final logo is revealed, maybe.

When that happens, we'll need to make changes to https://github.com/Automattic/social-logos first, then propagate those changes / update the package's version in the Calypso repo and the Jetpack repo.

This will also need to be updated in Core. I created an issue to keep track of it here:
WordPress/gutenberg#53223

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Aug 1, 2023
@jeherve jeherve transferred this issue from Automattic/wp-calypso Aug 1, 2023
@jeherve jeherve changed the title Update Twitter logo - Sharing Buttons, Social icons block Sharing / Social: update Twitter logo Aug 1, 2023
@jeherve jeherve added [Type] Janitorial [Pri] Normal [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Extra Sidebar Widgets [Feature] Theme Tools [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin and removed [Type] Feature Request labels Aug 1, 2023
@bobmatyas
Copy link
Contributor

@syhussaini
Copy link

7140561-zen

I confirmed that he the Plan to update the logo is on hold as the new X logo is currently an interim logo.

@staproehl
Copy link

7368162-zen

Let user know the plan to update the logo is on hold as the new X logo is currently an interim logo.

@rakshitwesley
Copy link

Requested here: 7394377-zd-a8c

@laurelfulford
Copy link
Contributor

Hi @syhussaini @staproehl @rakshitwesley! The X logo is available in Jetpack and on WP.com as of early-ish Oct (added in #33134). Instead of replacing the bird icon, it's a separate option under the share options (similar to how core handled it in the social icons block, with the two different icons available). Anyone who wants to use it will need to update their share buttons to add the X option:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Extra Sidebar Widgets [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Sharing Post sharing, sharing buttons [Feature] Theme Tools [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin [Pri] Normal [Type] Janitorial
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants