Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichText: replace deprecated multiline prop with simple multiple instances (Donations block) #33642

Closed
Tracked by #32865
jeherve opened this issue Oct 17, 2023 · 1 comment · Fixed by #33778
Closed
Tracked by #32865

RichText: replace deprecated multiline prop with simple multiple instances (Donations block) #33642

jeherve opened this issue Oct 17, 2023 · 1 comment · Fixed by #33778
Assignees
@jeherve
Labels
[Block] Donations Earn Earn features [Pri] Normal [Type] Janitorial
Milestone
jetpack/12.8

Comments

@jeherve
Copy link
Member

jeherve commented Oct 17, 2023 •
edited
Loading

See WordPress/gutenberg#54310

Primary issue: #32865
@jeherve jeherve mentioned this issue Oct 17, 2023
Closed
@jeherve jeherve changed the title RichText: replace deprecated multiline prop with simple multiple instances (Donations block) https://github.com/WordPress/gutenberg/pull/54310 RichText: replace deprecated multiline prop with simple multiple instances (Donations block) Oct 17, 2023
@jeherve jeherve self-assigned this Oct 17, 2023
@jeherve jeherve added this to the jetpack/12.8 milestone Oct 18, 2023
@anomiex
Copy link
Contributor

anomiex commented Oct 18, 2023

Looks like the only place we use this, we're setting it to false anyway?

jetpack/projects/plugins/jetpack/extensions/blocks/donations/amount.js

Line 106 in 8849299

multiline={ false }

@jeherve jeherve mentioned this issue Oct 25, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Block] Donations Earn Earn features [Pri] Normal [Type] Janitorial
Projects
None yet
Milestone
jetpack/12.8
Development

Successfully merging a pull request may close this issue.

Donations: remove unneeded multiline prop Automattic/jetpack
2 participants
@jeherve @anomiex