Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Janitorial: handle deprecation of TEMPLATEPATH and STYLESHEETPATH #33874

Open
Tracked by #32865
jeherve opened this issue Oct 31, 2023 · 3 comments
Open
Tracked by #32865

Janitorial: handle deprecation of TEMPLATEPATH and STYLESHEETPATH #33874

jeherve opened this issue Oct 31, 2023 · 3 comments

Comments

@jeherve
Copy link
Member

jeherve commented Oct 31, 2023

The TEMPLATEPATH and STYLESHEETPATH constants have been deprecated. get_template_directory() and get_stylesheet_directory() should be used instead.
-- https://core.trac.wordpress.org/ticket/18298

In Jetpack CRM

'path' => TEMPLATEPATH . '/' . $zbs->template_path . '/'

'path' => STYLESHEETPATH . '/' . $zbs->template_path . '/'

In Jetpack

if ( false === defined( 'STYLESHEETPATH' ) ) {


Primary issue: #32865

@jeherve
Copy link
Member Author

jeherve commented Oct 31, 2023

@Automattic/avengers Is that something you could look at for the CRM plugin?

Thank you!

@jeherve
Copy link
Member Author

jeherve commented Oct 31, 2023

@david-binda I'd like to have your take on this.

Related conversation: p7H4VZ-2F7-p2
This eventually led to D51494-code, which was ported to Jetpack in #17563.

I'm thinking that now that r56635 happened, we could completely revert that hot fix?

What do you think? What's your timeline on porting those changes from Core to wpcom?

@jeherve jeherve self-assigned this Oct 31, 2023
@ice9js ice9js modified the milestones: jetpack/12.8, jetpack/12.9 Nov 26, 2023
@ice9js ice9js removed this from the jetpack/12.9 milestone Dec 18, 2023
@jeherve
Copy link
Member Author

jeherve commented Dec 18, 2023

@david-binda Did you have the chance to look at this?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants