Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React compatibility: Use new createRoot API #38480

Closed
Tracked by #37951
coder-karen opened this issue Jul 23, 2024 · 2 comments · Fixed by #38495
Closed
Tracked by #37951

React compatibility: Use new createRoot API #38480

coder-karen opened this issue Jul 23, 2024 · 2 comments · Fixed by #38495
Assignees

Comments

@coder-karen
Copy link
Contributor

Issue

In React 18, importing createRoot from react-dom was deprecated, so ideally we'll fix up instances of this.

Related warnings:

Warning: You are importing createRoot from "react-dom" which is not supported. You should instead import it from "react-dom/client". visible on the Jetpack settings page.

Parent React 19 compatibility issue: #37951

@anomiex
Copy link
Contributor

anomiex commented Jul 23, 2024

Looks like just one instance was added since this was previously fixed in #28710.

@coder-karen
Copy link
Contributor Author

coder-karen commented Jul 24, 2024

Thanks! Looks like there are two separate issues related to createRoot, so I'll address them both.
Edit - no - just the one, thanks for clarifying in the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants