Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Podcast Feed Update] Add Refresh Button to Podcast Page #3478

Merged
merged 4 commits into from
Jan 28, 2025
Merged

[Podcast Feed Update] Add Refresh Button to Podcast Page #3478

merged 4 commits into from
Jan 28, 2025

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Jan 23, 2025 •
edited
Loading

Description

  • This PR adds the refresh button to the podcast and fake the refresh in order to show the snackbar with the result ok
  • This will be behind a local feature flag for now
  • See: 3LuZimaaH5tGKxIkOpjYAZ-fi-956_15707

Fixes #3477

Testing Instructions

  1. Open a podcast
  2. Tap on the 3 dots to open more options
  3. See the new refresh button ✅
  4. Tap to refresh
  5. After 2 seconds you should see the snackbar with ok result

Screenshots or Screencast

Screen_recording_20250124_101922.webm

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@mebarbosa mebarbosa added [Area] Podcast Page [Project] Podcast feed update Allow users to manually trigger a podcast feed update. labels Jan 23, 2025
@mebarbosa mebarbosa added this to the 7.82 milestone Jan 23, 2025
@mebarbosa mebarbosa requested a review from a team as a code owner January 23, 2025 19:09
@mebarbosa mebarbosa requested review from MiSikora and removed request for a team January 23, 2025 19:09
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 23, 2025 •
edited
Loading

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitd2e3ede
Direct Downloadpocketcasts-app-prototype-build-pr3478-d2e3ede.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitd2e3ede
Direct Downloadpocketcasts-automotive-prototype-build-pr3478-d2e3ede.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitd2e3ede
Direct Downloadpocketcasts-wear-prototype-build-pr3478-d2e3ede.apk

@mebarbosa mebarbosa added [Type] Feature Adding a new feature. and removed [Area] Podcast Page labels Jan 24, 2025
@mebarbosa mebarbosa merged commit be9fb55 into main Jan 28, 2025
17 checks passed
@mebarbosa mebarbosa deleted the task/podcast-feed-update-add-refresh-button branch January 28, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiSikora MiSikora MiSikora approved these changes

Assignees
No one assigned
Labels
[Project] Podcast feed update Allow users to manually trigger a podcast feed update. [Type] Feature Adding a new feature.
Projects
None yet
Milestone
7.82
Development

Successfully merging this pull request may close these issues.

[Podcast feed update] Add Refresh Button in Podcast View
3 participants
@mebarbosa @wpmobilebot @MiSikora