Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Podcast Index chapters attribute 'toc' #3480

Open
1 task done
geekygecko opened this issue Jan 24, 2025 · 0 comments
Open
1 task done

Add support for the Podcast Index chapters attribute 'toc' #3480

geekygecko opened this issue Jan 24, 2025 · 0 comments
Assignees
Labels
[Area] Chapters Episode chapters [Type] Bug Not functioning as intended.

Comments

@geekygecko
Copy link
Member

Description

Internal reference: p1737627384554359/1737627371.981699-slack-C02A333D8LQ

The Podcast Index chapters spec has the attribute toc that we don't currently process. We should use it to hide any chapter that has toc set to false.

https://github.com/Podcastindex-org/podcast-namespace/blob/main/chapters/jsonChapters.md

toc (optional - boolean) If this property is present and set to false, this chapter should not display visibly to the user in either the table of contents or as a jump-to point in the user interface. It should be considered a "silent" chapter marker for the purpose of meta-data only. If this property is set to true or not present at all, this should be considered a normal chapter for display to the user. The name "toc" is short for "table of contents".

Step-by-step reproduction instructions

  1. Play the episode 1728 - "Hatchet Man" - No Agenda
  2. Open the full screen player
  3. Tap chapters

Notice the following chapter appears, but it shouldn't.

Screenshots or screen recording

Image

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

Google Pixel 9, Android 15, Pocket Casts 7.80

@geekygecko geekygecko added [Area] Chapters Episode chapters [Type] Bug Not functioning as intended. labels Jan 24, 2025
@MiSikora MiSikora self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Chapters Episode chapters [Type] Bug Not functioning as intended.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants