Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blank Canvas Blocks] Evaluate 'base' CSS variable generation #3420

Closed
pbking opened this issue Mar 8, 2021 · 1 comment
Closed

[Blank Canvas Blocks] Evaluate 'base' CSS variable generation #3420

pbking opened this issue Mar 8, 2021 · 1 comment
Milestone

Comments

@pbking
Copy link
Contributor

pbking commented Mar 8, 2021

Blank Canvas Blocks has expectations of the availability of particular CSS variables generated from the "custom" block of theme.json. If those variables aren't defined and available then the page won't be correct.

Until we have "theme.json castcading" any theme that leverages Blank Canvas Blocks as a parent will either:

  • BE REQUIRED to express all variables in the parent theme.json (including any new ones)
  • need to have all default css variables defined by default which is also loaded with the polyfill CSS.

This task is to explore the second option. Hopefully as something that could happen at Blank Canvas Blocks' "build" cycle.

@pbking
Copy link
Contributor Author

pbking commented Mar 23, 2021

The BESTEST solution seems to be represented here: WordPress/gutenberg#30147

I'm going to close this in lieu of that proven solution.

@pbking pbking closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant