Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia Themes: Multuple issues with handling of Cover Block colors #5182

Closed
jordesign opened this issue Dec 10, 2021 · 2 comments · Fixed by #5212
Closed

Varia Themes: Multuple issues with handling of Cover Block colors #5182

jordesign opened this issue Dec 10, 2021 · 2 comments · Fixed by #5212

Comments

@jordesign
Copy link
Contributor

This is an umbrella issue to gather multiple open issues related to the current handling of Cover blocks by Varia.

  1. At some point it appears that the default text color display of Varia themes became different between the editor (where it appears white) and the front end (where it appears dark grey). The symptoms of this are reported in 2 different issues:

o #5181
o #4993

  1. It appears that Varia themes don't adjust the font color for contrast when the opacity of the cover overlay changes, or the darkness of the background color itself changes..

o #5051

@jordesign
Copy link
Contributor Author

I've got a test page/site up specifically for this if it helps
PdA1qf-f-p2

@scruffian scruffian self-assigned this Dec 16, 2021
@scruffian
Copy link
Member

I think we can fix this by removing the extra code that is targeting cover blocks as part of color annotations. The problem is that it will change the frontend for some users, so I'm not sure if its a good idea...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants