PHP Upgrade: Compatibility issues found in 000-debug

[shantanu2704]

The following issues were found when scanning branch master for compatibility problems:

• Warning in 000-debug/logger.php: Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$stuff" was used, and possibly changed (by reference), on line 41.

  vip-go-mu-plugins/000-debug/logger.php

  Line 46 in 2f4d90e

  foreach ( func_get_args() as $arg )

• Warning in 000-debug/logger.php: Since PHP 7.0, functions inspecting arguments, like debug_backtrace(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$stuff" was used, and possibly changed (by reference), on line 41.

  vip-go-mu-plugins/000-debug/logger.php

  Line 63 in 2f4d90e

  $backtrace = debug_backtrace(false);

• Warning in 000-debug/logger.php: Since PHP 7.0, functions inspecting arguments, like debug_backtrace(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$stuff" was used, and possibly changed (by reference), on line 41.

  vip-go-mu-plugins/000-debug/logger.php

  Line 87 in 2f4d90e

  $backtrace = debug_backtrace(false);

• Warning in 000-debug/logger.php: Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$stuff" was used, and possibly changed (by reference), on line 113.

  vip-go-mu-plugins/000-debug/logger.php

  Line 115 in 2f4d90e

  $args = func_get_args();

This is an automated report.

[GaryJones]

Lines 41 and 113 is simply return $stuff;, so that seems like a fixable false positive cc @jrfnl

[jrfnl]

@GaryJones In the current version of PHPCompatibility line 46 would already no longer be reported. Would you mind opening an issue about the code sample for the lo() function (line 113/115) in PHPCompatibility ?

[pschoffer]

@jrfnl thanks for a quick reply! We are using PhpCompatibility 9.3.5, which seems to be the current that generates these issues.

In both cases (line 46 and 113) the issue seems to be the conditional return statement before func_get_args. I created an issue as you asked.

[pschoffer]

@shantanu2704 same goes for the other two warnings in this file. It is harder to detect there programmatically, but the $stuff value is only used in read-only context, meaning it is not a compatibility issue. I will continue to clean the code which should remove this and others warning in the future, but it should not be a blocker.

[pschoffer]

This was now addressed in #1919