Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting: CSV exports should exclude hidden columns #10093

Closed
nagpai opened this issue Jan 7, 2025 · 4 comments
Closed

Reporting: CSV exports should exclude hidden columns #10093

nagpai opened this issue Jan 7, 2025 · 4 comments
Labels
category: core WC Payments core related issues, where it’s obvious. focus: reporting

Comments

@nagpai
Copy link
Contributor

nagpai commented Jan 7, 2025

Description

Currently, CSV exports from transactions, payouts and disputes list report view, end up exporting all columns, including hidden columns in the UI. The CSV exports also exclude the Channel column

Testing instructions

  1. Browse to Payments > Transactions
  2. Make sure you have more than 25 transactions, or trigger server export ( Unless - this PR that deprecates JS based export is merged )
  3. Make sure a few columns are hidden for the list report.
  4. Click on the download button
  5. Make sure you see a notification of the export being sent to your email
  6. In the CSV received over email, check that you see all columns including those hidden

Expected behavior

  1. Only visible columns in UI should be exported
  2. The Channel column should be exported correctly in the transactions report, if it is chosen in the UI.

Additional context

@nagpai nagpai added category: core WC Payments core related issues, where it’s obvious. focus: reporting labels Jan 7, 2025
@Jinksi
Copy link
Member

Jinksi commented Jan 8, 2025

This looks like it is a duplicate of #8183

@nagpai
Copy link
Contributor Author

nagpai commented Jan 14, 2025

Thanks @Jinksi . I am closing this in favor of #8313

@nagpai nagpai closed this as completed Jan 14, 2025
@Jinksi
Copy link
Member

Jinksi commented Jan 14, 2025

PS, I recommend we use the Close as duplicate button to indicate that this was not completed.

@Jinksi Jinksi closed this as completed Jan 14, 2025
@Jinksi
Copy link
Member

Jinksi commented Jan 14, 2025

It gives the issue an awesome status badge with a link to the relevant issue.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: core WC Payments core related issues, where it’s obvious. focus: reporting
Projects
None yet
Development

No branches or pull requests

2 participants